search

thoughtbot / refills

[no longer maintained]
http://refills.bourbon.io
MIT License
1.5k stars 148 forks source link

Move to a split layout #427

Closed creuter closed 7 years ago

creuter commented 7 years ago

This is visually more interesting, lets us remove some code, and removes the necessity to toggle to see the code you're referencing.

screencapture-localhost-4567-1489066839081

(Note, the refills were doubled up in the above screenshot to see what it would look like once we have a few more components. That doubling has been removed)

ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input"]'
ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input"]'
ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input"]'
ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tm > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tm > .ace_text-input"]'
ghost commented 7 years ago

I found 1 accessibility errors:

'http://localhost:4567/ | critical | Form elements must have labels | ["#dropdown-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#dropdown-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#dropdown-snippets > div:nth-of-type(3) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(1) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input", "#tooltipped-snippets > div:nth-of-type(2) > .snippet-code.ace_editor.ace-tomorrow > .ace_text-input"]'