search

thoughtbot / shoulda-context

Shoulda Context makes it easy to write understandable and maintainable tests under Minitest and Test::Unit within Rails projects or plain Ruby projects.
MIT License
239 stars 58 forks source link

Add Rails 4 support. #19

Closed caike closed 11 years ago

caike commented 11 years ago

Mix shoulda-context in MiniTest::Spec if present and part of ActiveSupport::TestCase's ancestors.

This is a simple suggestion for adding support to upcoming Rails 4, which now has its base test class inheriting from MiniTest::Spec instead of Test::Unit::TestCase.

I'm not expecting this pull-request to merged right away, as it doesn't include any tests or Appraisal support for Rails 4, but I'd love to hear your thoughts on this approach.

simonedamico commented 11 years ago

When this will be merged?

travisjeffery commented 11 years ago

Done.

simonedamico commented 11 years ago

That was fast :+1: