search

thoughtbot / shoulda-matchers

Simple one-liner tests for common Rails functionality
https://matchers.shoulda.io
MIT License
3.53k stars 909 forks source link

Problem when running the tests #1538

Open HeitorMC opened 1 year ago

HeitorMC commented 1 year ago

Hey guys, I was trying to run the tests with bundle exec rake but I don't know why, something is going wrong :thinking:

Here's the error:

image

I've already tried to bundle install and also updated the bundler version to 2.4.3, but it didn't work :disappointed:

I'm currently using: Ruby 3.2.0 (by asdf) Bundler 2.4.3 Pop_Os 22.04 (I don't know if this information can be helpful too)

Update: This happens when you try to run the bin/setup. If we try to run 

bundle check <path.../.../shoulda-matchers/gemfiles/rails_7_0.gemfile> || bundle install --gemfile='path/../shoulda-matchers/gemfiles/rails_7_0.gemfile' --retry 1'

If you run bundle exec rake, it will work :expressionless:

Why is this behavior happening? :thinking:

vsppedro commented 1 year ago

Hi @HeitorMC, thanks for reporting this issue. I'll take a look as soon as possible.

HeitorMC commented 1 year ago

Cool @VSPPedro, thank you for help! Please, let me know if there's anything I can do to help you with this issue :)

vsppedro commented 1 year ago

Sorry I couldn't replicate the issue, but if bundle exe rake is working then you can ignore this error.

You can run BUNDLE_GEMFILE=gemfiles/rails_7_0.gemfile bundle install to try to install just the missing gems, but it should work without that. We'll keep this open in case someone else stumbles across this or we find more information about the issue. Thanks!

HeitorMC commented 1 year ago

Alright, thank you for the feedback @VSPPedro. Please, let me know if there are any issues on shoulda-matchers that I can work on :handshake:

vsppedro commented 1 year ago

No problem, glad to help, @HeitorMC. Let me think...

What do you think about updating Rubocop or the dependencies in the Gemfile?

If you want a bigger challenge take a look at the conversation in this PR: https://github.com/thoughtbot/shoulda-matchers/pull/1381, there's probably a bug in the allow_value matcher.

You can also pick any issue that I was assigned, if you want, because at the moment I'm giving attention to shoulda-context.

@mcmire, do you have something in mind for the next release?

mcmire commented 1 year ago

@VSPPedro One thing I think we should continue to pursue is removing old Rubies and put out another major release. Ruby 2.7 will hit EOL at the end of the month so we might as well get a head start and drop it now! That will coincide with a new release of shoulda that I want to get out soon.

As for features/fixes, however, I'll have to look at the backlog more closely, but I skimmed through just now and found some smaller ones:

Stevo-S commented 1 year ago

For what it's worth, I ran into this issue as well. Both on Ubuntu 22.04 (WSL) and Mac OS 11.6 (Intel CPU).

bundle exec rake was failing and only started working after running BUNDLE_GEMFILE=gemfiles/rails_7_0.gemfile bundle install.