thoughtbot / shoulda-matchers

Simple one-liner tests for common Rails functionality
https://matchers.shoulda.io
MIT License
3.51k stars 912 forks source link

feat: Make `ValidateComparisonOfMatcher` inherit from `ValidationMatcher` #1567

Closed matsales28 closed 1 year ago

matsales28 commented 1 year ago

This PR intends to refactor the ValidateComparisonOfMatcher class to make it inherit from ValidationMatcher to continue on that pattern and make it consistent across all validation classes.

We are also removing some existing methods in the ValidationMatcher class from the ValidateNumericalityOfMatcher class.