thoughtbot / shoulda-matchers

Simple one-liner tests for common Rails functionality
https://matchers.shoulda.io
MIT License
3.51k stars 912 forks source link

Remove the with qualifier on define_enum_for matcher #1589

Closed amalrik closed 10 months ago

amalrik commented 10 months ago

closes #1462

amalrik commented 10 months ago

@matsales28 done :)

vsppedro commented 10 months ago

Hello @amalrik, it's been a while! I hope you are doing great.

Oh, I had forgotten about this issue. I genuinely appreciate your contribution!

The error on the CI is related to an intermittent test. Fortunately, @matsales28 has proposed a solution for it. Once he merges his pull request, we can resume the CI to verify the changes.

Thank you!