search

thoughtbot / shoulda-matchers

Simple one-liner tests for common Rails functionality
https://matchers.shoulda.io
MIT License
3.51k stars 912 forks source link

adds failure_message_when_negated to have_secure_password_matcher #1593

Closed amalrik closed 9 months ago

amalrik commented 10 months ago

closes #1187 credits goes to @Kutomore Im just adding missing specs to his solution on a new PR because I cant override PR #1192

amalrik commented 9 months ago

Looks good to me! I believe it would be a great idea to squash the commits and include @Kutomore as a co-author.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-github

What do you think?

Good idea. Done

vsppedro commented 9 months ago

Thank you for your contribution, @amalrik!