search

thoughtbot / shoulda-matchers

Simple one-liner tests for common Rails functionality
https://matchers.shoulda.io
MIT License
3.5k stars 911 forks source link

fix inline documentation about is_greater_than in validate_comparison_of matcher #1616

Closed jeduardo824 closed 6 months ago

jeduardo824 commented 6 months ago

This PR fixes the initial example the inline documentation of the validate_comparison_of matcher. In the example, the matcher is using greater_than(...) in the tests, but it is actually is_greater_than(...).

vsppedro commented 6 months ago

Hey, @jeduardo824, great find!

I noticed another one at https://github.com/thoughtbot/shoulda-matchers/blob/a078b461852bf47611713daac4de2ad6d04834be/lib/shoulda/matchers/active_model/validate_comparison_of_matcher.rb#L49

Could you include this in your pull request too?

Thanks a lot for your contribution!

jeduardo824 commented 6 months ago

Hey, @jeduardo824, great find!

I noticed another one at

https://github.com/thoughtbot/shoulda-matchers/blob/a078b461852bf47611713daac4de2ad6d04834be/lib/shoulda/matchers/active_model/validate_comparison_of_matcher.rb#L49

Could you include this in your pull request too?

Thanks a lot for your contribution!

Job done!

vsppedro commented 6 months ago

Thank you!