thoughtbot / shoulda

Makes tests easy on the fingers and the eyes
http://www.thoughtbot.com/community
MIT License
2.21k stars 197 forks source link

Added support to Rails 6.0 and shoulda-matchers 4.1 #269

Closed correalucas closed 5 years ago

mcmire commented 5 years ago

Hey, I don't know if this was an accident or not, but regardless, thanks for the reminder on this :)

correalucas commented 5 years ago

Hi Elliot, I closed the PR because it didn't passed in build. but i can open it again if you want. The tests are passing and the code may need improvement. I will be glad if you could give me a feedback on this.

mcmire commented 5 years ago

Yeah, this would need some work for sure in order to get everything playing nice with each other. I've a rough plan in my head for a good while now on how to get this working. Let me get back to you on this.