thoughtbot / superglue

A productive library for Classic Rails, React and Redux
https://thoughtbot.github.io/superglue/
MIT License
327 stars 8 forks source link

Add type annotations to `lib/utils/request.ts` #76

Closed jho406 closed 6 days ago

jho406 commented 1 week ago

Context

Continuing on the typescript conversion. There are 8 functions in lib/utils/request.ts these are utilities functions are used by Superglue to manage request objects.

Issue

Lets convert all 8 functions in lib/utils/request.ts to typescript. Most of the conversion should be straightforward, the only one that may be tricky is argsForFetch, which return literally Fetch arguments, you'll need to find a return type for it.

jho406 commented 6 days ago

I'll pick this one up too.