search

thoughtbot / suspenders

A Rails template with our standard defaults.
https://thoughtbot.com
MIT License
4.02k stars 530 forks source link

Generated Dockerfile doesn't work with flightdeck #1189

Open minaslater opened 6 months ago

minaslater commented 6 months ago

On a recent project with Lift-Off, I had trouble deploying the image that's built from the Suspenders generated Dockerfile (which I assume is the Rails default) to the thoughtbot flightdeck platform. The state of that project was as follows:

I can add more specifics once I have some time to dig into it, but due to project time crunch, we replaced the Dockerfile with one that we know for sure works on flightdeck, with small application-specific tweaks, and that was deployed successfully.

Since Suspenders and flightdeck are both thoughtbot products, it'd be nice for them to get along out of the box.

stevepolitodesign commented 6 months ago

Thank you for opening this.

the Suspenders generated Dockerfile (which I assume is the Rails default)

This is correct. The generated Dockerfile is indeed created from Rails.

Since Suspenders and flightdeck are both thoughtbot products, it'd be nice for them to get along out of the box.

I agree. Would it be as simple as having Suspenders generate this Dockerfile instead?

minaslater commented 6 months ago

I agree. Would it be as simple as having Suspenders generate this Dockerfile instead?

I think it can be! Definitely a straightforward solution.

Although, I'll probably still want to figure out what was causing the issues anyway, but that shouldn't block your new release.

stevepolitodesign commented 6 months ago

I'll probably still want to figure out what was causing the issues anyway, but that shouldn't block your new release.

Awesome, for now I'll probably continue forward with the new release, but I think this would make for a good follow-up.