search

thoughtbot / suspenders

A Rails template with our standard defaults.
https://thoughtbot.com
MIT License
4.01k stars 530 forks source link

How do we want to handle Ruby linting now that Rails ships with a solution? #1214

Open stevepolitodesign opened 3 months ago

stevepolitodesign commented 3 months ago

Rails 7.2 now ships with rubocop-rails-omakase.

However, with the introduction of #1148, we risk having two linting mechanisms.

stevepolitodesign commented 3 months ago

One solution could be to simply skip this option.

https://github.com/rails/rails/blob/ff0ef93e28d4919ffd8bf130132b7b7e3435c67a/railties/lib/rails/generators/app_base.rb#L102

DoodlingDev commented 1 month ago

From the notes about this change--

If you or your team has developed a particular house style that brings you joy, you should cherish that.

standardrb and standard-rails work well, we're accustomed to them, migrating away from tbot preferences (even if it's Rails standard now) feels like the antithesis of suspenders.

Should we move to omakase as our recommended and most-oft-used system, then maybe we change suspenders?

stevepolitodesign commented 1 month ago

@DoodlingDev

If you or your team has developed a particular house style that brings you joy, you should cherish that.

Ha! I didn't even see that. That makes me feel good about the changes introduced in #1223