thoughtbot / suspenders

A Rails template with our standard defaults.
https://thoughtbot.com
MIT License
4.01k stars 529 forks source link

Add Neat and Bitters #197

Closed croaky closed 11 years ago

gylaz commented 11 years ago

What's bitters? http://rubygems.org/search?query=bitters

mjankowski commented 11 years ago

I think we want to leave flutie for the vies helpers, and make sure bourbon/neat/bitters are providing what the flutie styles used to, in terms of good defaults.

croaky commented 11 years ago

@mjankowski Yeah, I think that's right. I keep forgetting Flutie doesn't have that now.

croaky commented 11 years ago

@gylaz https://github.com/thoughtbot/bitters I've seen it be the first thing that @frechg and @alexbaldwin add to new projects.

croaky commented 11 years ago

@plapier Do you use Bitters on every new project? What do you think about including it in Suspenders?

frechg commented 11 years ago

@croaky we are in the process of overhauling some of these things. Most of the designers have found that we have our own preferences on how "bitters" is set up and have our own versions that we use on our respective projects.

I think bitters will remain something that we work on and something that others can use in projects, but if bitters were a part of suspenders I'd probably remove it and add my personal version.

Each person having their own version might sound counter intuitive, but it makes sense to me because with css there isn't ever really a single most correct way to achieve something. So many times the best solution is the one you can understand and work with most efficiently.

frechg commented 11 years ago

@croaky Neat should definitely be a part of suspenders though.

croaky commented 11 years ago

@frechg Cool. Could you review the Gemfile and application.css.scss files in this commit?

https://github.com/thoughtbot/suspenders/pull/202