search

thoughtbot / suspenders

A Rails template with our standard defaults.
https://thoughtbot.com
MIT License
4.02k stars 530 forks source link

Pipelines: separate pipeline apps created #689

Closed rikkipitt closed 8 years ago

rikkipitt commented 8 years ago

Hey guys,

Thanks for all your hard work on v1.35.0, it's come a long way since #617. Some nice touches added, especially running Heroku commands against staging as default!

However, when creating a new app the staging and production apps are generated as usual, but two pipeline apps are also generated instead of just the one. One has the staging app set as staging, the other has the production app set as production...

Thought I'd report this behaviour so we can start debugging. Ping #639. I'll try and take a look in the new year.

rikkipitt commented 8 years ago

Looks like the second pipeline command should be add rather than create.

         run  heroku pipelines:create jemcode -a jemcode-staging --stage staging --remote staging from "."
Creating jemcode pipeline... done
Adding jemcode-staging to jemcode pipeline as staging... done
         run  heroku pipelines:create jemcode -a jemcode-production --stage production --remote production from "."
Creating jemcode pipeline... done
Adding jemcode-production to jemcode pipeline as production... done

Reference: https://github.com/thoughtbot/suspenders/blob/d53de08ef0b7588c5916585916b890e417741dd5/lib/suspenders/adapters/heroku.rb#L63-L77

zamith commented 8 years ago

That seems correct to me. I'm creating a PR with that fix, and let's see what others have to say. Thanks.

rikkipitt commented 8 years ago

Cheers @zamith, I was noting this down to sort out next week but you beat me to it! I've had a quick check of your fixes, look good.

zamith commented 8 years ago

@rikkipitt Oh, sorry for that. I had some free time right now. :)

rikkipitt commented 8 years ago

No worries, at least one of us sorted it. It's a feature I've been anticipating for a while since Heroku announced Pipelines! Cheers!

tute commented 8 years ago

Thank you! Closing in favor of the related PR.