Closed rocket-turtle closed 1 year ago
With ruby-3.0.4 I get these two errors:
..................F........................................F................
Failures:
1) Terrapin::CommandLine::PosixRunner behaves like a command that does not block does not block if the command outputs a lot of data
Failure/Error: expect($?.exitstatus).to eq(0)
expected: 0
got: 1
(compared using ==)
Shared Example Group: "a command that does not block" called from ./spec/terrapin/command_line/runners/posix_runner_spec.rb:5
# ./spec/support/nonblocking_examples.rb:8:in `block (3 levels) in <top (required)>'
# ./spec/support/nonblocking_examples.rb:6:in `block (2 levels) in <top (required)>'
2) When an error happens does not blow up if running the command errored before execution
Failure/Error: undef_method :exitstatus
FrozenError:
can't modify frozen object: pid 28760 exit 0
# ./spec/support/unsetting_exitstatus.rb:4:in `undef_method'
# ./spec/support/unsetting_exitstatus.rb:4:in `singleton class'
# ./spec/support/unsetting_exitstatus.rb:3:in `assuming_no_processes_have_been_run'
# ./spec/terrapin/errors_spec.rb:55:in `block (2 levels) in <top (required)>'
Finished in 6.18 seconds (files took 0.40862 seconds to load)
76 examples, 2 failures
Failed examples:
rspec ./spec/terrapin/command_line/runners/posix_runner_spec.rb:5 # Terrapin::CommandLine::PosixRunner behaves like a command that does not block does not block if the command outputs a lot of data
rspec ./spec/terrapin/errors_spec.rb:54 # When an error happens does not blow up if running the command errored before execution
@mike-burns Any chance you can have a quick look at this MR.
I think it gets CI green and other MRs could be testet/ merged.
Maybe test can be moved to GitHub Actions afterwards. https://github.com/thoughtbot/terrapin/pull/16/files
Thank you @rocket-turtle!
I think mocka 1.10 is not working with bourne (1.6.0 - November 20, 2014 (15,5 KB))
I tested it on my maschine and it's green for ruby-2.4.10 / ruby-2.5.5 / ruby-2.6.8 / ruby-2.7.6