search

thoughtbot / terrapin

Run shell commands safely, even with user-supplied values
Other
250 stars 18 forks source link

Remove posix runner and unsupported posix-spawn gem #19

Closed elisuh closed 1 year ago

elisuh commented 1 year ago

This PR removes Terrapin's PosixRunner, which relies on the now unsupported posix-spawn gem. Improvements to Ruby (as of Ruby 3.0) means that posix-spawn is now less performant than native Ruby implementation. You can read more about this in this posix-spawn issue, specifically this comment.

We feel it's no longer necessary to provide posix support as there are no longer advantages over native. Since Ruby 2.x will no longer be supported soon, it's important that we maintain Terrapin to be compatible with the lowest supported version of Ruby.

brian-penguin commented 1 year ago

Oh dang looks like you are already on it https://github.com/thoughtbot/terrapin/pull/16

elisuh commented 1 year ago

Ahhh that was all @joshuaclayton!!! But yea it's done, wanted to put it in a separate PR though since it's such a big change.