Make sure we read stderr to not end up with a hang when the stderr buffer fills

thoughtbot / terrapin

Run shell commands safely, even with user-supplied values

Other

244 stars 20 forks source link

Make sure we read stderr to not end up with a hang when the stderr buffer fills #5

Closed mmangino closed 1 year ago

jyurek commented 6 years ago

NB: This was originally posted as https://github.com/thoughtbot/cocaine/pull/97 and thanks to @mmangino for moving it over.

mfo commented 6 years ago

I reached this PR via paperclip (5.3.?) which is impacted.

This error occured after I upgraded to the last version of image magick (imagemagick: stable 7.0.7-26 (bottled), HEAD). Now image magick returns much more verbose errors which ends up hanging up the process (my case when thumbnailing a corrupted JPEG).

Hope it will land soon in terrapin/paperclip

sribalakumar commented 5 years ago

Anytime soon this is expected to be merged. Waiting for this PR as we are stuck on the same problem.

elisuh commented 1 year ago

@mmangino Hello! Are you still looking to get this merged? I tried to rebase your branch with main and push it up, but don't have write access. Once you rebase with main and CI is good, we can get this merged. Thanks so much for your patience. 😄

stuzart commented 5 months ago

this was merged into master and not main, so the problem still exists in the latest 1.0.1 release