thoughtbot / vim-rspec

Run Rspec specs from Vim
https://robots.thoughtbot.com
MIT License
657 stars 108 forks source link

add options `g:rspec_not_match_spec_filename` to skip filename checking #109

Closed mz026 closed 7 years ago

mz026 commented 8 years ago

With this option we can run rspec without requiring naming test file as *_spec.rb

gylaz commented 8 years ago

Thank you for the pull request, @mz026.

I'm curious why you ran into such a situation. To be frank, I don't think we should support this, as it goes against the RSpec conventions.

mz026 commented 8 years ago

@gylaz We really enjoy the experience of vim-rspec since it makes our TDD process much faster. But the testing framework we are using has different naming convention from RSpec, that's why we need an option to release the file name restriction. Thanks anyway!!

gylaz commented 8 years ago

@mz026 Which framework are you using? You may want to have a look at https://github.com/janko-m/vim-test (it supports multiple).

mz026 commented 8 years ago

@gylaz vim-test looks cool! Currently we are using pork as our testing framework: https://github.com/godfat/pork

dgmstuart commented 7 years ago

@gylaz looks like this can possibly be closed?

gylaz commented 7 years ago

Yep, closing.