thoughtbot / vim-rspec

Run Rspec specs from Vim
https://robots.thoughtbot.com
MIT License
657 stars 108 forks source link

Buffer bleeding through run output using Vim 8.0 #120

Open jondavidjohn opened 8 years ago

jondavidjohn commented 8 years ago

Upon attempting to upgrade to Vim 8.0, I'm getting some funky output when running specs via vim-rspec. For reference I'll show you what it looks like for me under 7.4

vim-74-rspec

When I upgrade to Vim 8.0, it looks as if the underlying buffer bleeds through the output before I dismiss it.

vim-80-rspec

Additionally, I show in that demonstration that the same thing does not happen when I manually run rspec via straight shell execution (!)

Additionally, I'm customizing the rspec command like so (not sure if it's related)

let g:rspec_command = ':w | !clear && bin/rspec -I . {spec}'
dgmstuart commented 7 years ago

@jondavidjohn I've tried out that rspec_command running on vim 8 and haven't managed to reproduce those issues.

My vimrc is here: https://github.com/dgmstuart/dotfiles/blob/master/.vimrc

...and here's my version info:

:version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Sep 19 2016 20:38:47)
MacOS X (unix) version
Included patches: 1-5
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +cmdline_hist    -ebcdic          -gettext         +listcmds        +mouse_sgr       +persistent_undo +smartindent     +textobjects     +wildmenu
+arabic          +cmdline_info    +emacs_tags      -hangul_input    +localmap        -mouse_sysmouse  +postscript      +startuptime     +timers          +windows
+autocmd         +comments        +eval            +iconv           -lua             +mouse_urxvt     +printer         +statusline      +title           +writebackup
-balloon_eval    +conceal         +ex_extra        +insert_expand   +menu            +mouse_xterm     +profile         -sun_workshop    -toolbar         -X11
-browse          +cryptv          +extra_search    +job             +mksession       +multi_byte      +python          +syntax          +user_commands   -xfontset
++builtin_terms  +cscope          +farsi           +jumplist        +modify_fname    +multi_lang      -python3         +tag_binary      +vertsplit       -xim
+byte_offset     +cursorbind      +file_in_path    +keymap          +mouse           -mzscheme        +quickfix        +tag_old_static  +virtualedit     -xpm
+channel         +cursorshape     +find_in_path    +lambda          -mouseshape      +netbeans_intg   +reltime         -tag_any_white   +visual          -xsmp
+cindent         +dialog_con      +float           +langmap         +mouse_dec       +num64           +rightleft       -tcl             +visualextra     -xterm_clipboard
-clientserver    +diff            +folding         +libcall         -mouse_gpm       +packages        +ruby            +termguicolors   +viminfo         -xterm_save
+clipboard       +digraphs        -footer          +linebreak       -mouse_jsbterm   +path_extra      +scrollbind      +terminfo        +vreplace
+cmdline_compl   -dnd             +fork()          +lispindent      +mouse_netterm   +perl            +signs           +termresponse    +wildignore
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -l
ncurses -liconv -framework Cocoa   -mmacosx-version-min=10.11 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0/darwin-thread-multi-2l
evel/CORE -lperl -lm -lutil -lc -F/usr/local/Cellar/python/2.7.12/Frameworks -framework Python   -lruby.2.3.0 -lobjc -L/usr/local/Cellar/ruby/2.3.1/lib
jondavidjohn commented 7 years ago

Thanks for giving it a shot @dgmstuart!