search

thoughtbot / vim-rspec

Run Rspec specs from Vim
https://robots.thoughtbot.com
MIT License
657 stars 108 forks source link

Add support for running JS tests #51

Closed gabebw closed 10 years ago

gabebw commented 10 years ago

It runs teaspoon {spec} by default, but can be changed using g:javascript_comamnd, exactly like g:rspec_command.

calebhearth commented 10 years ago

:+1:

gylaz commented 10 years ago

JavaScript tests seem to be outside of the scope of a plugin named vim-rspec. Does it make more sense to make a new plugin for this (following unix philosophy), or rename this plugin to something more general?

gabebw commented 10 years ago

We're postponing merging this while we think about that exact issue, Greg.

@christoomey and I are working on a new plugin that can run more than just RSpec. We started it this morning and it lives here: https://github.com/gabebw/vim-spec-runner.

I don't want to rename this plugin because that will break Vim configurations for people who have it in their Vundle.

gylaz commented 10 years ago

@gabebw I was thinking of a separate, focused vim plugin just for JS tests, instead of a combined spec runner plugin.

jferris commented 10 years ago

It would be nice to have a way to make the same bindings and behavior work with multiple runners. For example, if I hit <Leader> t, it would be nice if that would run whatever test I'm using, regardless of the type. It would also be nice to have it run the last test regardless of type if I'm editing a model or something. That kind of behavior is common to all spec runners.

gylaz commented 10 years ago

@gabebw From our discussions, does it sound like we can close this?

gabebw commented 10 years ago

Yes, we can close this.

croaky commented 10 years ago

Did this work get extracted to https://github.com/gabebw/vim-spec-runner?

gabebw commented 10 years ago

@croaky Yes, that's what @christoomey and I are working on.