search

thoughtbot / vim-rspec

Run Rspec specs from Vim
https://robots.thoughtbot.com
MIT License
656 stars 108 forks source link

Require g:rspec_runner explicitly #94

Open gylaz opened 9 years ago

gylaz commented 9 years ago

If g:rspec_runner is not provided the g:rspec_command will be piped to GUI vim as-is.

This allows users to use vim-dispatch with GUI vim.

gylaz commented 9 years ago

ping @christoomey @jferris

gylaz commented 9 years ago

The only problem I see here is that out-of-the box, this doesn't work for MacVim because the default spec command won't work without !. Could we maybe provide a default runner only when a custom command and a custom runner aren't provided? Any other ideas?

christoomey commented 9 years ago

Overall I think the explicitness requirement is fine, and the readme updates seems good to cover the change. I did have one concern about recommending they add their custom script to the plugin bin/ directory which I commented on inline.

gylaz commented 9 years ago

Thanks, @christoomey.