search

thoughtbot / vim-rspec

Run Rspec specs from Vim
https://robots.thoughtbot.com
MIT License
656 stars 108 forks source link

Removing "spec" as the last_spec in RunAllSpecs #95

Closed hiattp closed 7 years ago

hiattp commented 9 years ago

Forcing rspec spec in RunAllSpecs overrides --default-path in the local .rspec config, and "spec" is RSpec's default anyway if the default path is not explicitly set.

dgmstuart commented 7 years ago

Ooh! I didn't know about --default-path. +1 from me

Does it still make sense to have let s:default_command = "rspec {spec}" in that case - so that spec basically functions as a placeholder, or is that confusing for someone reading the code because it suggests that the command which will actually be run is an explicit rspec spec?

hiattp commented 7 years ago

Hmm wasn't confusing to me, I'd probably leave as is?

gylaz commented 7 years ago

Merged. Thanks for the contribution @hiattp!