Closed jessica-townsend closed 4 months ago
The existing version of this has an inner container which uses fit-content
width and auto margin to center align the items when they are smaller than the available width. I think we still want that.
If I try to recreate it with the justification in the editor, it looks right with a small number of items, but the content at the start gets cut off when there are enough items to need scrolling.
I see what you mean @douglas-johnson , it would have been nice to just use the flex layout for the entire block but I'll rewrite it to include the inner container
@douglas-johnson I made an update to this which uses a row block as the inner container with the custom class so we can apply the fit-content
property, but there are still a couple issues:
inline-size
instead of flex-basis
seems to fix this in dev tools.Thought Catalog develop is up to date with this latest version. I've been trying to factor away the need to use the Reel Clip block and use sizing & layout options that are already available in core, but if flex-basis
isn't working with fit-content
I'm thinking we'll have to add the Reel Clip block after all. Let me know what you think!
Yeah it seems like it has to use reel clip to have the same functionality, sorry for the re-work.
@douglas-johnson updated on develop with the reel clip block
Related Issues
What Was Accomplished
How It Was Tested
How To Test
Open Questions
"allowJustification": false
wasn't working for me. I still see Justification settings on the new Reel block. We will never use anything besides thestart
justification so having this setting available is pointless. The only other option I see is to hide justification is to disable all settings usingallowEditing
for this block, but that will also disable the vertical alignment setting which I think would be nice to have. Let me know what you think.Deploy Steps