thoughtis / cata-blocks

Block Editor components for use with the Cata theme.
GNU General Public License v3.0
1 stars 0 forks source link

Issue#156/auto slider #161

Closed jessica-townsend closed 1 month ago

jessica-townsend commented 2 months ago

Related Issues

What Was Accomplished

How It Was Tested

How To Test

douglas-johnson commented 1 month ago

This variation is coming out slightly different than other variations I've see. I'm using the YouTube variation of the embed block as my point of reference.

The YouTube variation says YouTube and shows their logo in both the List View on the left side and the Block panel on the right side.

The Auto-Slider variation of the Reel block doesn't indicate its an auto-slider once its selected. The list view and the block panel both say Reel. Since it doesn't animate in the editor its hard to tell it apart from the regular reel.

If the variation were registered in JavaScript instead of block.json, is it more clearly labeled?

jessica-townsend commented 1 month ago

@douglas-johnson I did more reading in the documentation for block variations and I realized I needed to add the isActive property: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-variations/#using-isactive

This is on thoughtnet develop