tmlfs cleanup error as it detects directory is not tmlfs root

felipemm commented 4 months ago

First Stop

[X] I have read and agreed to the ThoughtSpot Dev Tools EULA.
[X] I understand that if I have a critical issue with ThoughtSpot, I should reach out to my designated Account Executive and Solutions Consultant team instead of cs_tools.
[X] I searched the cs_tools documentation, with the integrated search.

Platform Configuration

╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                      │
│           Info snapshot taken on 2024-05-14                                                                          │
│                                                                                                                      │
│               CS Tools: 1.5.5                                                                                        │
│         Python Version: Python 3.9.16 (main, Jan  4 2023, 11:12:52)                                                  │
│    [Clang 14.0.0 (clang-1400.0.29.202)]                                                                              │
│            System Info: Darwin (detail: macOS-12.7.5-x86_64-i386-64bit)                                              │
│      Configs Directory: /Users/ {anonymous} /Library/Application Support/cs_tools                                    │
│    Activate VirtualEnv: source "/Users/ {anonymous} /Library/Application Support/cs_tools/.cs_tools/bin/activate"    │
│          Platform Tags: macosx-12.6-x86_64                                                                           │
│                                                                                                                      │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Description

Tried to cleanup my current tmlfs, got error that directory is not root of tmlfs, but it is.

Also, raised error is regarding CSToolsError class not taking arguments, which seems a bug on this class or how it is manipulated.

billdback-ts commented 4 months ago

@felipemm I'm adding a fix today, but you can get past this by creating a file called ".tmlfs" in the root directory. It's supposed to be created on initial FS creation, but wasn't.

boonhapus commented 3 months ago

@felipemm if you upgrade to 1.5.6 , this should be resolved.

curl -sSL https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py | python3 - --install

felipemm commented 3 months ago

just to make sure: this cleanup only remove logs, not TMLs?

It seems it is not working:

billdback-ts commented 3 months ago

Yes, it only removes old logs, not TML files. Is that list of TML files in the logs folder? Looks like you are printing the liveboard folder.

boonhapus commented 2 months ago

Closing as the underlying issue seems to be resolved. Feel free to re-open if there are still issues!

thoughtspot / cs_tools