thoughtspot / cs_tools

Scale your ThoughtSpot adoption with tools created by the ThoughtSpot Solutions Consulting organization.
https://thoughtspot.github.io/cs_tools/
Other
8 stars 6 forks source link

Issue with Archiver Remove #168

Closed robertholmes3 closed 1 week ago

robertholmes3 commented 1 week ago

First Stop

Platform Configuration

╭──────────────────────────────────────────────────────────────────────────────╮ │ │ │ Info snapshot taken on 2024-09-01 │ │ │ │ CS Tools: 1.5.9 │ │ Python Version: Python 3.10.14 (main, Jul 10 2024, 09:56:15) │ │ [Clang 15.0.0 (clang-1500.3.9.4)] │ │ System Info: Darwin (detail: macOS-14.5-arm64-arm-64bit) │ │ Configs Directory: /Users/ {anonymous} /Library/Application │ │ Support/cs_tools │ │ Activate VirtualEnv: source "/Users/ {anonymous} /Library/Application │ │ Support/cs_tools/.cs_tools/bin/activate" │ │ System Python Path: /Users/ {anonymous} /Library/Application │ │ Support/cs_tools/.cs_tools/bin/python │ │ Platform Tags: macosx-14.5-arm64 │ │

Description

I am able to run all other tools but when I try remove we get the error:

AttributeError: 'RESTAPIv1' object has no attribute 'post'

Need to upload log files securely?

No response

boonhapus commented 1 week ago

@robertholmes3 can you update to 1.5.10b3 ? I should have just fixed this one.

curl \
    --silent --show-error --location-trusted \
    https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py \
    | python3 - --install --beta
robertholmes3 commented 1 week ago

Thank @boonhapus, this worked! Just FYI the --export-only does not seem to work

boonhapus commented 1 week ago

What do you mean by it doesn't work @robertholmes3 ? 🤔 When provided, this should skip the delete content and delete tag steps.

robertholmes3 commented 1 week ago

apologies - for me it didn't export any tml @boonhapus

boonhapus commented 1 week ago

Did you also specify --directory <someDir> as well? We have both because many customers will run archiver remove --directory <someDir> --export-only in one run to backup content that would be deleted, and then simply archiver remove afterwards.

robertholmes3 commented 1 week ago

ah i missed --directory ! @boonhapus

boonhapus commented 1 week ago

I can add some cli validation to whine if you supply --export-only without --directory , that's a better UX than a seemingly silent failure. Thanks!

boonhapus commented 1 week ago

Will close this one now, the fix provided in the beta will fold into the latest public release as well. Feel free to reopen the issue if you run into any other bugs!