Bulk Sharing Tool Issue

alexwillingham98 commented 1 year ago

First Stop

[X] I have read and agreed to the ThoughtSpot Dev Tools EULA.
[X] I understand that if I have a critical issue with ThoughtSpot, I should reach out to my designated Account Executive and Solutions Consultant team instead of cs_tools.
[X] I searched the cs_tools documentation, with the integrated search.

Platform Configuration

Info snapshot taken on 2023-07-19 │ │ │ │ CS Tools: 1.4.4 │ │ Python Version: Python 3.11.3 (tags/v3.11.3:f3909b8, Apr 4 2023, 23:49:59) [MSC v.1934 64 bit (AMD64)] │ │ System Info: Windows (detail: Windows-10-10.0.19045-SP0) │ │ Configs Directory: C:\Users\alexw\AppData\Roaming\cs_tools │ │ Activate VirtualEnv: C:\Users\alexw\AppData\Roaming\cs_tools.cs_tools\Scripts\Activate.ps1 │ │ Platform Tags: win-amd64

Description

The Bulk Sharing tool doesn't seem to show permissions for a table with a lot of columns. I will do my best to provide a screenshot but can't show everything due to data privacy. (I whited out the column names)

issue

alexwillingham98 commented 1 year ago

Additionally, this does affect the ability to change/edit perms.

boonhapus commented 1 year ago

My guess is we're not properly handling the security/metadata/permissions call. This might take a bit to debug and this is one of those commands I wanted to rewrite as well.

Are you trying to use Column Level Security here @alexwillingham98 ?

alexwillingham98 commented 1 year ago

Yes, we currently have CLS on our worksheets because we have unencrypted username fields that only 1 or two groups can have access to at the moment.

boonhapus commented 1 year ago

@alexwillingham98 are you able to see any table columns' permissions? I'm not finding the same behavior on our internal clusters.

alexwillingham98 commented 1 year ago

Yes it works fine for most tables, just not the ones with a lot of columns.

alexwillingham98 commented 1 year ago

any update on this issue? I updated to the current cs_tools version and am still seeing this issue

boonhapus commented 1 year ago

Hey @alexwillingham98 -- sorry, I haven't had much time to look into this one. I can't reproduce this one locally, would you be open to meeting live so I can observe the behavior in your own environment? I'd like to test a few things as well.

I am in UTC-5 / US Central. If you're open to this, please send me an email and we'll find a time to look at this.

boonhapus commented 1 year ago

@alexwillingham98 thanks for your patience here... I've added a fix for this (I believe), can you grab the latest beta and let me know if it's resolved?

(Invoke-WebRequest `
    -Uri https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py `
    -UseBasicParsing `
).Content | python - --reinstall --beta

For the v1.5 release, we're going to be redesigning this tool and including some extra functionality here. The existing UX doesn't really scale well with a large amount of columns. 😄

alexwillingham98 commented 1 year ago

Hey - just tried this out this morning and it seems to be working fine. Thanks!

boonhapus commented 1 year ago

Closing this as marked fixed in v1.4.10 !

thoughtspot / cs_tools