thoughtstem / morugamu

7 stars 6 forks source link

Symbol sheets are getting compiled too soon #22

Closed srfoster closed 6 years ago

srfoster commented 6 years ago

I noticed a place in the code where we're violating the "Separation of Concerns" principle: https://en.wikipedia.org/wiki/Separation_of_concerns

There's a place where we're mixing up rule system definitions and printing -- two different aspects of the project. We need to fix this.

In the render functions for the various rule systems, the render function returns a list of assets that can be printed. One of those assets is a big sheet of symbols. But the render function shouldn't be doing the job of tiling those symbols. They should be returned as individual images in the larger list.

They should be tiled onto a sheet later (in one of the printing files).