thoughtsunificator / instagram-dm-unsender

Instagram userscript that enable batch unsending of DMs
MIT License
36 stars 3 forks source link

IDMU: Finished #24

Closed PatoRoxo closed 4 months ago

PatoRoxo commented 6 months ago

I tried to use this script as an alternative to the other one but every time I click "Unsend all DMs", it just scrolls up and after a few seconds it says IDMU: Finished but it didn't delete anything. I'm not a coder so I don't understand if I'm doing anything wrong, I'm using Google Chrome

gl4d commented 6 months ago

same issue happening, it's loading a few msgs pages up and then displaying "IDMU: Finished", even if i manually load all the pages, i get the same message but it deleted 0 message.

using latest version of IDMU & chrome

Teko012 commented 6 months ago

It is indeed seems to be broken. @thoughtsunificator do you think this issue is fixable?

thoughtsunificator commented 6 months ago

Could you post your console logs please ?

Teko012 commented 6 months ago

Could you post your console logs please ?

@thoughtsunificator This is the only line that shows up along with the popup:

unsend-strategy.js:138 TypeError: clickTarget.click is not a function
    at clickElementAndWaitFor (async-events.js:39:14)
    at UIMessage.clickElementAndWaitFor (ui-component.js:32:10)
    at UIMessage.openActionsMenu (ui-message.js:72:40)
    at UIMessage.isMyOwnMessage (ui-message.js:26:47)
    at async findMessages (dom-lookup.js:14:26)
    at async DefaultUI.createUIPIMessages (default-ui.js:41:27)
    at async #processBatches (unsend-strategy.js:125:29)
    at async #startUnsending (ui.js:83:3)
#processBatches @ unsend-strategy.js:138
await in #processBatches (async)
run @ unsend-strategy.js:88
#startUnsending @ ui.js:83
#onUnsendThreadMessagesButtonClick @ ui.js:161
(anonymous) @ ui.js:63
thoughtsunificator commented 6 months ago

@Teko012 Thans, I managed to reproduce the bug and am working on a fix. Will be releasing it ASAP.

thoughtsunificator commented 6 months ago

Fixed in https://github.com/thoughtsunificator/instagram-dm-unsender/releases/tag/v0.5.15

Teko012 commented 5 months ago

@thoughtsunificator It seems to be indeed fixed, thanks, however, it seems like it's still not working properly. It unsends 2 messages, and then it writes Finished, even though there are way more messages still on the screen loaded. Can you maybe check that as well?

Teko012 commented 5 months ago

Also, I checked it a bit further, but nothing shows in the console either, it just pretends its finished.

PatoRoxo commented 5 months ago

I am now running the v0.5.15 but the same thing happens as I said in my first comment. It scrolls up, loads for a while and says "IDMU: Finished". After that, I can't scroll down to see the dms unless I refresh the page.

thoughtsunificator commented 5 months ago

Yep I got the same issue on another thread. I am looking into it thanks for the heads up!

Teko012 commented 5 months ago

yeah, I also noticed the scrolling getting stuck aftwards. Thanks for checking it!

thoughtsunificator commented 5 months ago

I have released a new version, please check it and let me know.

Teko012 commented 5 months ago

I tested now with 0.5.16, but I still observe the same behaviour: it deletes one message, then says Finished, and constantly trying to scroll up afterwards.

gl4d commented 5 months ago

also still having problems here, using 0.5.16 it scrolls up, sometimes its deleting a few messages but most of the time it deletes nothing, ignores a LOT of messages and just pops up the "IDMU: Finished"

from my understanding (and in my case): the bot seems to assume that there's nothing to delete if the other person sent multiple messages in a row, even tho there might be some but just a little bit further down

here's an exemple: https://www.youtube.com/watch?v=HZp3cuGQYnI

thoughtsunificator commented 5 months ago

also still having problems here, using 0.5.16 it scrolls up, sometimes its deleting a few messages but most of the time it deletes nothing, ignores a LOT of messages and just pops up the "IDMU: Finished"

from my understanding (and in my case): the bot seems to assume that there's nothing to delete if the other person sent multiple messages in a row, even tho there might be some but just a little bit further down

here's an exemple: https://www.youtube.com/watch?v=HZp3cuGQYnI

Thanks I'll look into it !

EDIT:

Looks like it's unloading the messages that aren't into the viewport, Will be releasing a fix ASAP.

Teko012 commented 5 months ago

Great, thank you!

sorryzzss commented 5 months ago

Thanks

Teko012 commented 5 months ago

@thoughtsunificator Do you happen to have any progress on this by any chance?

thoughtsunificator commented 5 months ago

@thoughtsunificator Do you happen to have any progress on this by any chance?

Sorry for the late reply, I'm still in the process of writing more tests and reworking the batch process.

thoughtsunificator commented 5 months ago

0.5.17 is out, I believe most things have been fixed.

Teko012 commented 5 months ago

@thoughtsunificator Thank you for the work, it seems to be indeed working. There is a bug I experience, sometimes it gets stuck on Found X messages, unsending... and doesn't continue until "Stop processing" is hit and then the unsend button again, then it continues. Nothing is shown on the console.

DirectGames commented 5 months ago

Still doesn't work indeed. Keeps looking for messages but doesn't delete.

thoughtsunificator commented 5 months ago

@DirectGames Do you have any console logs I can look at.

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: DirectGames @.> Sent: Monday, January 29, 2024 1:38:45 PM To: thoughtsunificator/instagram-dm-unsender @.> Cc: Romain Lebesle @.>; Mention @.> Subject: Re: [thoughtsunificator/instagram-dm-unsender] IDMU: Finished (Issue #24)

Still doesn't work indeed. Keeps looking for messages but doesn't delete.

— Reply to this email directly, view it on GitHubhttps://github.com/thoughtsunificator/instagram-dm-unsender/issues/24#issuecomment-1914614134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUI2D4LZRUS3VVXWT6SVHL3YQ6J5LAVCNFSM6AAAAABBAKK6HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGYYTIMJTGQ. You are receiving this because you were mentioned.Message ID: @.***>

DirectGames commented 5 months ago

@DirectGames Do you have any console logs I can look at. Sent from Outlook for iOShttps://aka.ms/o0ukef ____ From: DirectGames @.> Sent: Monday, January 29, 2024 1:38:45 PM To: thoughtsunificator/instagram-dm-unsender @.> Cc: Romain Lebesle @.>; Mention @.> Subject: Re: [thoughtsunificator/instagram-dm-unsender] IDMU: Finished (Issue #24) Still doesn't work indeed. Keeps looking for messages but doesn't delete. — Reply to this email directly, view it on GitHub<#24 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUI2D4LZRUS3VVXWT6SVHL3YQ6J5LAVCNFSM6AAAAABBAKK6HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGYYTIMJTGQ. You are receiving this because you were mentioned.Message ID: @.***>

https://imgur.com/a/UwHUkwx

gl4d commented 5 months ago

Same here; It looks for a few msgs and successfully deletes them, successfully load some pages up but it instantly gets stuck when there's a lot/a few messages in a row, only from the other person. stopping and starting the script kinda "works" but takes a lot of time since it doesn't scroll up much and gets stuck pretty fast.

thoughtsunificator commented 5 months ago

There's still an issue when the interlocutor messages makes up the entire chat window. As I said earlier, for some reason Instagram removes message from the DOM they are no longer in the viewport.

A temporary workaround would be to scroll up to your oldest message manually.

I will release another fix soon.

brog-io commented 5 months ago

I'm also experiencing this issue, I also can't see batch size and Load all DMs. This might be due me being on the EU version of the site. I hope this gets fixed and it seems this is the only script that can delete all DMs.

thoughtsunificator commented 5 months ago

I'm also experiencing this issue, I also can't see batch size and Load all DMs. This might be due me being on the EU version of the site. I hope this gets fixed and it seems this is the only script that can delete all DMs.

I removed these buttons in the newer versions no worry.

thoughtsunificator commented 5 months ago

I just released v0.5.17-patched. Hope it works for you.

PatoRoxo commented 5 months ago

Tried to run it, looked like it was doing something for a few seconds then it said "IDMU:Finished" and then "Done. 0 messages unsent." right next to the button to unsend.

I just get this in the console. DOMException: Aborted loadMoreMessages @ dom-lookup.js:66 await in loadMoreMessages (async) fetchAndRenderThreadNextMessagePage @ ui-messages-wrapper.js:13 fetchAndRenderThreadNextMessagePage @ default-ui.js:33 fetchAndRenderThreadNextMessagePage @ uipi.js:40 fetchAndRenderThreadNextMessagePage @ idmu.js:43

next @ unsend-strategy.js:117

await in #next (async) run @ unsend-strategy.js:88

startUnsending @ ui.js:90

onUnsendThreadMessagesButtonClick @ ui.js:125

(anonymous) @ ui.js:73

Teko012 commented 5 months ago

For me, the previous version worked, this one doesn't do anything at all.

thoughtsunificator commented 5 months ago

Note: There's been yet another change in Instagram UI :

2024-02-01_21-12

exuded commented 4 months ago

any fix yet? still not working

thoughtsunificator commented 4 months ago

@exuded can you file a new issue ?

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: exuded @.> Sent: Monday, February 12, 2024 5:28:06 PM To: thoughtsunificator/instagram-dm-unsender @.> Cc: Romain Lebesle @.>; Mention @.> Subject: Re: [thoughtsunificator/instagram-dm-unsender] IDMU: Finished (Issue #24)

any fix yet? still not working

— Reply to this email directly, view it on GitHubhttps://github.com/thoughtsunificator/instagram-dm-unsender/issues/24#issuecomment-1939081938, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUI2D4MCYBUOLEE4LQN57ZLYTI7JNAVCNFSM6AAAAABBAKK6HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGA4DCOJTHA. You are receiving this because you were mentioned.Message ID: @.***>

thoughtsunificator commented 4 months ago

Looks like there are multiple issues here, so I'll ask that you file a new bug if you still have one while making sure to include all details.