thoughtworks-jumpstart / guides

đź—ş The official guide book for the ThoughtWorks Jumpstart program
https://guides.jumpstart.sh
15 stars 9 forks source link

Update react-hooks.md #92

Closed enwee closed 4 years ago

enwee commented 4 years ago

typos

jsstrn commented 4 years ago

Thanks @enwee for proposing the changes. Looking at the React documentation they use the term "function components" rather than "functional components"

From the React documentation:

This function is a valid React component because it accepts a single “props” (which stands for properties) object argument with data and returns a React element. We call such components “function components” because they are literally JavaScript functions. – Components and Props – React

Could you make the changes such that the term "functional component" is corrected to "function component" instead?

Thank you.

jsstrn commented 4 years ago

Also, it is a good idea to use better titles for your git commit messages. For example, you might say: "Amend functional to function components"

enwee commented 4 years ago

thanks for your guiding comments, i actually used the [edit this doc] button on the html page itself and did not that its comments field was actually a git commit message. Following yr comments i wanted to edit the content of the change request but again could not find how to so i created a new edit. prob not the best way.

On Monday, February 24, 2020, Jesstern Rays notifications@github.com wrote:

Also, it is a good idea to use better titles for your git commit messages. For example, you might say: "Amend functional to function components"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thoughtworks-jumpstart/guides/pull/92?email_source=notifications&email_token=AN63IUKQ77OSTCQTXEUDRFTREOMKTA5CNFSM4KZYDP2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXHRHI#issuecomment-590248093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN63IUJBULLPCSYUTTHYY63REOMKTANCNFSM4KZYDP2A .

jsstrn commented 4 years ago

Closing this as it has been resolved in #93