thoughtworks / build-your-own-radar

A library that generates an interactive radar, inspired by https://thoughtworks.com/radar/.
GNU Affero General Public License v3.0
2.21k stars 1.04k forks source link

[WIP] build: switch from prettier/eslint to biomejs #371

Closed setchy closed 7 months ago

setchy commented 7 months ago

[!NOTE]
I'll leave this as a draft proposal until I seek feedback from the maintainers.
If we agree to move forward, I can work through addressing the errors and getting the branch building/operating

This PR proposes a switch from ESLint + Prettier to BiomeJS, a more performant and simpler to use formatter and linter combo.

This PR includes any automated fixes.

The following rules that have been relaxed temporarily from error to warn so that the npm run quality script can continue

"linter": {
  "enabled": true,
  "rules": {
    "recommended": true,
    "complexity": {
      "noForEach": "warn",
      "noUselessConstructor": "warn",
      "useArrowFunction": "warn",
      "useLiteralKeys": "warn",
      "useOptionalChain": "warn"
    },
    "correctness": {
      "noInnerDeclarations": "warn"
    },
    "performance": {
      "noAccumulatingSpread": "warn",
      "noDelete": "warn"
    },
    "style": {
      "noParameterAssign": "warn",
      "noUselessElse": "warn",
      "noUnusedTemplateLiteral": "warn",
      "noVar": "warn",
      "useConst": "warn",
      "useDefaultParameterLast": "warn",
      "useNodejsImportProtocol": "warn",
      "useSingleVarDeclarator": "warn",
      "useTemplate": "warn"
    },
    "suspicious": {
      "noAssignInExpressions": "warn",
      "noGlobalIsNan": "warn",
      "noRedundantUseStrict": "warn"
    }
  }
},