search

thoughtworks / cruisecontrol.rb

CruiseControl for Ruby. Keep it simple.
http://cruisecontrolrb.thoughtworks.com
Apache License 2.0
613 stars 206 forks source link

New svn:externals format breaks cc.rb #1

Open pgr0ss opened 14 years ago

pgr0ss commented 14 years ago

If you have a subversion repository using the new svn externals (such as relative URLs), cc.rb says error when it tries to check the working copy to see if it's up to date.

For example, this is fine: external_path svn://rubyforge.org/var/svn/cruisecontrolrb/trunk/daemon

but this will break cc.rb: ^/passing_project caret_external

The arguments in the new format have been reversed, and cc.rb doesn't know how to handle it. Also, building the svn URL for the external is no longer straightforward. cc.rb would have to handle relative URLs and URLs rooted at the repository (such as the example above).

bguthrie commented 13 years ago

CC.rb's internal SVN test repositories have been upgraded to what I believe to be the latest version, so some part of this may have been resolved. As of June 2011, however, I view this as a low-priority issue. Patches welcome, tentatively assigning to a 2.1.0 milestone.

tobyhs commented 11 years ago

The commit above (tobyhs@b37c2bb) should also include tobyhs@09b84d5 (which is basically https://github.com/tobyhs/cruisecontrol.rb/tree/svn_externals_upgrade).