RoujingLiu commented 2 years ago

https://github.com/thoughtworks/metrik/issues/95 Divide the fetching progress into 3 "steps" and show: fetching new runs, fetching in-progress runs and fetching commits. Remove redundant emitCb during mapping of runs and commits. Fix the problem of SSE cached due to the webpack. Fix the problem of tests' name and services' name don't match.

codecov-commenter commented 2 years ago

Codecov Report

Merging #125 (acd46a4) into main (3b70143) will decrease coverage by 0.06%. The diff coverage is 93.97%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   94.26%   94.20%   -0.07%     
==========================================
  Files          88       93       +5     
  Lines        4306     4380      +74     
  Branches      251      258       +7     
==========================================
+ Hits         4059     4126      +67     
- Misses        124      126       +2     
- Partials      123      128       +5

Impacted Files	Coverage Δ
...n/metrik/project/constant/GithubActionConstants.kt	`0.00% <0.00%> (ø)`
...etrik/project/domain/repository/BuildRepository.kt	`80.95% <ø> (ø)`
...domain/service/githubactions/ExecutionConverter.kt	`100.00% <ø> (ø)`
...t/infrastructure/github/feign/GithubFeignClient.kt	`23.07% <ø> (ø)`
...infrastructure/jenkins/feign/JenkinsFeignClient.kt	`50.00% <ø> (ø)`
...n/metrik/project/rest/SynchronizationController.kt	`56.66% <ø> (ø)`
...in/metrik/project/rest/validation/EnumValidator.kt	`33.33% <0.00%> (ø)`
...astructure/github/feign/response/BranchResponse.kt	`50.00% <50.00%> (ø)`
...project/domain/service/githubactions/RunService.kt	`89.58% <88.88%> (ø)`
...ject/domain/service/githubactions/BranchService.kt	`94.44% <94.44%> (ø)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bbddbc...acd46a4. Read the comment docs.

hyrepo commented 2 years ago

@all-contributors please add @RoujingLiu for code

allcontributors[bot] commented 2 years ago

@hyrepo

I've put up a pull request to add @RoujingLiu! :tada: