thoughtworks / metrik

An easy-to-use, cross-platform measurement tool that pulls data out of CD pipelines and analysis the four key metrics for you.
MIT License
354 stars 87 forks source link

feat: change `PUT /project/:id` interface to escape unnecessary quotes character #150

Closed wildan3105 closed 1 year ago

wildan3105 commented 1 year ago

Fixes #149

Before

https://user-images.githubusercontent.com/7030099/219297637-ffd14f4f-ecca-4836-9e4c-e4cac746bb46.mp4

After

https://user-images.githubusercontent.com/7030099/219297261-9aaf96b7-09c9-45c0-85cd-a890da1abf88.mp4

wildan3105 commented 1 year ago

Hi @kevinlzw @xloypaypa when you have free time, can you please review this PR to fix #149 ? Thanks a lot and appreciate any feedback! 😄

wildan3105 commented 1 year ago

Also cc-ing @hyrepo and @zhe-zhao as the top contributors in this project 😄

kevinlzw commented 1 year ago

Hi @wildan3105, thank you for solving this issue! I will merge this PR and do a release.

kevinlzw commented 1 year ago

Hi @all-contributors please add @wildan3105 for code

allcontributors[bot] commented 1 year ago

@kevinlzw

I've put up a pull request to add @wildan3105! :tada:

wildan3105 commented 1 year ago

awesome!