search

thoughtworks / pacto

Pacto settles disputes between JSON providers and consumers
thoughtworks.github.io/pacto
MIT License
400 stars 58 forks source link

Contract generation not working #101

Closed jmmercadom closed 10 years ago

jmmercadom commented 10 years ago

The current version 0.3.0 the rake task generate is failing.

Apparently on this commit a8b4f59 the code related with this task was removed. This change leaved the test features/generate/generation.feature empty =/. By the way, the README is still showing this feature as available.

Why did we decided to remove this feature?

maxlinc commented 10 years ago

My fault. I gave @marcosccm the go-ahead.

Marcos: the generator method is only used at it's own spec T_T do you use it? the standalone version Generator.generate? Max: Not in polytrix. I probably will soon for apiblueprint to pacto though.. Marcos: are you deadly sure? that will allow me to clean a lot of code I think Max: Kill it. I've got git :-)

I don't use the rake task, I use Pacto.generate! That way it records the full contract - request and response.

I do have plans to improve generation, including Documentation-Driven Contracts and a WIP (but working) "tokenization" branch.

We can revert https://github.com/thoughtworks/pacto/commit/a8b4f59 now if it's needed, otherwise we might want to improve the design before bringing the feature back.

jmmercadom commented 10 years ago

I prefer to restore the crappy (functional) version until you finish the improved one and then we can replace the implementation.