Tech debt cleanup - Githubissues

maxlinc commented 9 years ago

Some cleanup to make it easier to start shifting to development that focuses on Swagger and starts getting away from Legacy contracts.

Contract, RequestClause, and ResponseClause are now effectively immutable
Created modules for format-specific (legacy, swagger) subclasses
Created separate fixture folders for different formats
Other miscellaneous cleanup, e.g. around error handling

Many tests still run only with the legacy contracts. You can switch them over to Swagger with the environment variable PACTO_DEFAULT_FORMAT, but most tests would fail. I'm going to take care of that in a separate PR to move from away from using Fabrication for creating sample contracts and moving to contract fixtures where we have both a legacy and a swagger version.

coveralls commented 9 years ago

Coverage increased (+0.09%) to 84.19% when pulling 8c4292d52d1bf78ed7b5b27d36d21129f5f6f9ee on maxlinc:cleanup into 996468520cd3583cd8dd9de9a2cc664057f9345b on thoughtworks:master.

coveralls commented 9 years ago

Coverage decreased (-1.1%) to 83.01% when pulling 8c4292d52d1bf78ed7b5b27d36d21129f5f6f9ee on maxlinc:cleanup into 996468520cd3583cd8dd9de9a2cc664057f9345b on thoughtworks:master.

thoughtworks / pacto

Tech debt cleanup #172