search

thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.89k stars 241 forks source link

Add support for Apple M1 #356

Closed pexa-abruno closed 2 years ago

pexa-abruno commented 2 years ago

Apple M1 script fails - Talisman currently only supports x86 and x86_64 architectures.

Follow instructions as per

https://thoughtworks.github.io/talisman/docs/installation/single-repository/

To Reproduce

Steps to reproduce the behavior:

  1. curl https://thoughtworks.github.io/talisman/install.sh > ~/install-talisman.sh
  2. chmod +x ~/install-talisman.sh
  3. mkdir repo
  4. cd repo
  5. ~/install-talisman.sh

Not running from inside a git repository... installing as a git template.

If you meant to install to a specific repo, 'cd' into that repo and run this script again.

Installing as a template will automatically add Talisman to any new repo that you 'init' or 'clone'.

No git template directory is configured. Let's add one. (this will override any system git templates and modify your git config file)

Git template directory: (/Users/abruno/.git-templates)

Talisman currently only supports x86 and x86_64 architectures. /Users/abruno/install-talisman.sh: line 105: INSTALL_ORG_REPO: unbound variable

Expected behavior

As documented

pexa-abruno commented 2 years ago

Using brew install talisman as an alternative works on M1, however would be good to update documentation.

svishwanath-tw commented 2 years ago

@pexa-abruno : I've fixed the install script. Could you check now if it works for you ?

pexa-abruno commented 2 years ago

Nope. Just tested

curl https://thoughtworks.github.io/talisman/install.sh > ~/install-talisman.sh

Talisman currently only supports x86 and x86_64 architectures. /Users/abruno/install-talisman.sh: line 105: INSTALL_ORG_REPO: unbound variable

pexa-abruno commented 2 years ago

Using curl https://raw.githubusercontent.com/thoughtworks/talisman/a8b8b8c63181c1560c8b1a8aed8235d6d2aebf8a/install.sh > ~/install-talisman.sh it worked on M1.

PR looks good, can merge.

pexa-abruno commented 2 years ago

OK, this also works - so it was merged.

https://raw.githubusercontent.com/thoughtworks/talisman/master/install.sh = GOOD

BUT

https://thoughtworks.github.io/talisman/install.sh = NOT UPDATED!