thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.89k stars 241 forks source link

Automatic update script fails on an Apple M1 Mac (arm64) #363

Open donnabelsey opened 2 years ago

donnabelsey commented 2 years ago

Describe the bug The automatic update script is currently failing on an M1 / arm64 Mac with the reason 'unsupported architecture'.

Your version of Talisman is outdated. Updating Talisman to v1.27.0
Talisman currently only supports x86 and x86_64 architectures.
If this is a problem for you, please open an issue: https://github.com/thoughtworks/talisman/issues/new
/tmp/update_talisman.bash: line 97: E_UNSUPPORTED_ARCH: unbound variable

To Reproduce

  1. Install on an M1 Mac
  2. Wait until an update is released
  3. Attempt to use Talisman (perform a commit with the pre-commit hook enabled, etc), which will trigger the automatic update check

Expected Behaviour arm64 should be recognised and the update should work

Additional Context In https://github.com/thoughtworks/talisman/issues/356 (commit 3184dac ) support was added to the Talisman install script for arm64, which works successfully. I suspect the update_talisman.sh script also needs a similar fix applied to add arm64 to the allowed list.