Closed vool closed 2 years ago
Merging #367 (33f2096) into master (e50270d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 33 33
Lines 1559 1559
=======================================
Hits 1087 1087
Misses 439 439
Partials 33 33
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e50270d...33f2096. Read the comment docs.
I've modified the existing golang scope to remove the vendor folder. https://github.com/thoughtworks/talisman/pull/371 I'm unsure if node_modules belongs in the same league.
Yes, I would think so, it is standard to place this under gitignore
I'm unsure if node_modules belongs in the same league.
@vool : Please resolve merge conflict. (preferably rebase against thoughtworks:master
or at least merge thoughtworks:master
into vool:master
)
Already up to date.
@vool : Please resolve merge conflict. (preferably rebase against
thoughtworks:master
or at least mergethoughtworks:master
intovool:master
)
Hi, I am using Talisman on a PHP project, the composer lock file contains lots of hashes which are always ok as it is autogenerated. Would be great to add support for PHP scope. Keith