Closed jmatias closed 2 years ago
Fix main.Version
reference in goreleaser.yml
@jmatias : At this point, the only thing preventing approval/merge is the increased binary size on non arm machines. Talisman build scripts used UPX to make the binary as small as can be. My worry in going ahead is that a lot of github issues will be created asking to reduce the binary size again. Thoughts ?
@jmatias : At this point, the only thing preventing approval/merge is the increased binary size on non arm machines. Talisman build scripts used UPX to make the binary as small as can be. My worry in going ahead is that a lot of github issues will be created asking to reduce the binary size again. Thoughts ?
Regardless of GoReleaser, the issue would still be there for ARM (though they are working on it, we could try building the source code from their main branch)
That being said, 8 MB nowadays does not feel like a whole lot — I would argue that it's acceptable for now until we find a way to either tap into the build hooks or do it post release. (And by that I mean just doing an empty release and then writing something ourselves that uploads the binaries).
I vote for keeping the 8 MB binaries for now.
Codecov Report
Continue to review full report at Codecov.