search

thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.91k stars 242 forks source link

[BugFix] Cannot set up talisman hook on repo paths that contain whitespaces. #377

Closed jmatias closed 2 years ago

jmatias commented 2 years ago

image

The fix is to set IFS to split only on new lines.

image

codecov[bot] commented 2 years ago

Codecov Report

Merging #377 (370d128) into master (fe4c766) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 370d128 differs from pull request most recent head 6035bd8. Consider uploading reports for the commit 6035bd8 to get more accurate results

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          33       33           
  Lines        1559     1559           
=======================================
  Hits         1087     1087           
  Misses        439      439           
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe4c766...6035bd8. Read the comment docs.