thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.87k stars 241 forks source link

use same checksum logic for talismanRC suggestion as during detection #417

Open second-frank opened 1 year ago

second-frank commented 1 year ago

Resolves #416

With this PR the git additions used for the detection scan are also taken into account when reporting the checksum suggestions for the .talismanrc file. Because evaluation of fileignoreconfig checksums during detection scans is based on filename pattern matching against the git additions too. (see ChecksumCompare.IsScanNotRequired() and ChecksumCalculator.CalculateCollectiveChecksumForPattern())


The program was tested solely for our own use cases, which might differ from yours.
Frank Seidel frank.seidel@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information