search

thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.87k stars 241 forks source link

Release 1.30.1: go: updates to go.mod needed #421

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

Describe the bug Talisman 1.30.1 fails to build due to the following error (full log here, error starts here):

  ==> go build -trimpath -o=/home/linuxbrew/.linuxbrew/Cellar/talisman/1.30.1/bin/talisman -ldflags=-X main.Version=1.30.1 ./cmd
  go: downloading github.com/bmatcuk/doublestar v1.3.4
  go: downloading github.com/sirupsen/logrus v1.8.1
  go: downloading github.com/spf13/afero v1.6.0
  go: downloading github.com/spf13/pflag v1.0.5
  go: downloading golang.org/x/text v0.3.8
  go: downloading golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f
  go: downloading gopkg.in/yaml.v2 v2.4.0
  go: downloading github.com/olekukonko/tablewriter v0.0.5
  go: downloading github.com/AlecAivazis/survey/v2 v2.2.12
  go: downloading github.com/fatih/color v1.12.0
  go: downloading github.com/cheggaaa/pb/v3 v3.0.8
  go: downloading github.com/common-nighthawk/go-figure v0.0.0-20200609044655-c4b36f998cf2
  go: downloading github.com/mattn/go-runewidth v0.0.12
  go: downloading github.com/mattn/go-colorable v0.1.8
  go: downloading github.com/mattn/go-isatty v0.0.12
  go: downloading github.com/VividCortex/ewma v1.1.1
  go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
  go: downloading github.com/rivo/uniseg v0.2.0
  go: downloading github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b
  go: updates to go.mod needed; to update it:
    go mod tidy

This error was observed on Ubuntu x86_64, but it is reproducible on macOS, too.

To Reproduce Steps to reproduce the behavior:

  1. Download and extract https://github.com/thoughtworks/talisman/archive/v1.30.1.tar.gz
  2. cd into the directory, and go build -trimpath -o=./talisman -ldflags="-X main.Version=1.30.1" ./cmd

Expected behavior Talisman should be successfully built. This requires go.mod to be updated.

Screenshots N/A

Desktop (please complete the following information): N/A

Smartphone (please complete the following information): N/A

Additional context This problem was observed while packaging Talisman for Homebrew in https://github.com/Homebrew/homebrew-core/pull/125184.

jmatias commented 1 year ago

@ZhongRuoyu Thanks for reporting this!

ZhongRuoyu commented 1 year ago

And thanks for the quick fix, @jmatias! We will ship 1.30.2 instead.