search

thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.92k stars 241 forks source link

Auto update version when pre-commit hook is invoked #434

Open pornchanok-tw opened 1 year ago

pornchanok-tw commented 1 year ago

Describe the bug Hi, there's a question from gordon-jetstar-tw and nueng-tw According to this statement image

Why there's no version update triggered when pre-commit hook triggered?

To Reproduce Steps to reproduce the behavior:

  1. run ./.git/hooks/bin/talisman --version image

  2. run ./.git/hooks/bin/talisman --githook pre-commit image

  3. run ./.git/hooks/bin/talisman --version again. the version still remain the same image

Expected behavior The version should be automatically updated to the latest version. (Now it's 1.31.0)

Desktop (please complete the following information):

tinamthomas commented 1 year ago

@pornchanok-tw could you verify that the TALSIMAN_HOME is configured to the same location (./.git/hooks/bin/talisman )

dougalg-js-tw commented 1 year ago

cc @gordon-jetstar-tw @nueng-tw

dougalg-js-tw commented 9 months ago

@tinamthomas this was not configured, but configuring it does not appear to resolve the issue