fileignoreconfig in talisman are not considered in scan mode - Githubissues

thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.

https://thoughtworks.github.io/talisman/

MIT License

1.87k stars 241 forks source link

fileignoreconfig in talisman are not considered in scan mode #451

Open aravindbuilt opened 5 months ago

aravindbuilt commented 5 months ago

I've added fileignoreconfig in .talismanrc. The observations are as follows

when I ran talisman --scan, the fileignoreconfig are not considered and scans the whole commit history
When I ran talisman --ignoreHistory --scan, the fileignoreconfig are included and scans the head

Expectation

fileignoreconfig should be included for all type of scans

Code Reference

https://github.com/thoughtworks/talisman/blob/f9b0c70b2b4da6f0144934ac3c186b9cc95ab83b/talismanrc/talismanrc.go#L104

System Details

OS: Mac OS
Version 1.32.0