thoughtworks / talisman

Using a pre-commit hook, Talisman validates the outgoing changeset for things that look suspicious — such as tokens, passwords, and private keys.
https://thoughtworks.github.io/talisman/
MIT License
1.87k stars 241 forks source link

Fix issue where CustomSeverities are not respected in config #459

Closed zph closed 1 month ago

zph commented 1 month ago

Original ability was added in: https://github.com/thoughtworks/talisman/pull/281

When trying out the functionality, it does not respect custom_severities as documented in the README.

This patch addresses it by including the porting of custom severities from the the same location where other config keys are copied

I've confirmed that it works both in a new test and in manual regression testing.

Fixes: https://github.com/thoughtworks/talisman/issues/364

Side note: I didn't include further changes but it looks like golang is auto-formatting code in the project differently than what's committed in the files I touched. It's a good idea to do a single code formatting re-write so you don't have a trickle of whitespace/formatting changes in PRs.