PyArray_Diagonal view transition for 1.8 (Trac #2136)

numpy-gitbot commented 11 years ago

Original ticket http://projects.scipy.org/numpy/ticket/2136 on 2012-05-19 by atmention:njsmith, assigned to unknown.

Starting in 1.8, PyArray_Diagonal is supposed to start returning a non-writeable view.

To do:

Make the (trivial) change at the bottom of PyArray_Diagonal
Update the numpy.diagonal documentation
Make a note in the release notes
Optionally, remove NPY_ARRAY_WARN_ON_WRITE flag. If so, see the below pull request to find the code to change. Even if we decide to keep it around for a rainy day, the message in array_might_be_written should have the references to diagonals removed.

numpy-gitbot commented 11 years ago

atmention:rgommers wrote on 2012-05-19

numpy-gitbot commented 11 years ago

atmention:rgommers wrote on 2012-05-19

Note, don't close this ticket once the change for 1.8 is made - there's a change to be made for 1.9 as well. See PR-280 for details.

numpy-gitbot commented 11 years ago

atmention:njsmith wrote on 2012-05-19

Shoot, I meant to put "File a new ticket for the 1.9 milestone" as the last item on the todo list and then forgot. Thanks for catching that :-)

thouis / numpy-trac-migration