search

thousandbrainsproject / tbp.monty

Monty is a sensorimotor learning framework based on the thousand brains theory of the neocortex.
https://thousandbrainsproject.readme.io
MIT License
107 stars 27 forks source link

RFC Configuration Management #14

Closed hlee9212 closed 1 day ago

hlee9212 commented 1 week ago

Migrated from previous repository. The RFC was placed on hold and the PR was kept open in the previous repository. No need to review now, this PR is not intended to be merged until we decide to implement.

vkakerbeck commented 1 week ago

I thought the process was that an RFC is merged once it is accepted? That doesn't mean that we have to implement it right away or that the author has to implement it (https://thousandbrainsproject.readme.io/docs/request-for-comments-rfc#implementing-an-rfc). I think a good next step would be for @nielsleadholm to review this RFC and then for us to have a meeting to talk through whether we want to change our config setup how you propose (we can set the timeline for it later). There is no rush to do decide this right now, I just wanted to point out that per our RFC process we can merge as soon as we decide that we want this. We don't have to wait until we have someone assigned to implement it right away.

vkakerbeck commented 1 week ago

Sounds good, that makes sense. And yes, that was my impression as well, that so far it is unclear what advantage Hydra gives that we can't achieve with our Python configs (even though we want to improve those for sure!). I like this plan to wait and see about feedback once we have more people using the code :)