Fixes bug that was preventing the creation of alert rules with third party notifications but without email notification
Fixes bug that was causing some fields (such as notifications and notifyOnClear) in alert rules to be reset when updating alert rules
Fixes bug that was causing the recipient list to change on every run (it was using an ordered list)
ThousandEyes API documentation states that to update alert rules, the full list of fields must be sent. Docs.
I should also note that while the fix is very simple, debugging these issues (apart from the recipient list order) was not easy and took me a full day basically, because there's still a lot about this codebase that I don't know.
Tests are passing:
go vet ./... && echo && go test ./...
? github.com/thousandeyes/terraform-provider-thousandeyes [no test files]
ok github.com/thousandeyes/terraform-provider-thousandeyes/thousandeyes (cached)
Tested the provider locally multiple times. Worked well in my tests, but please let me know if I can make it easier to review this and to verify.
ThousandEyes API documentation states that to update alert rules, the full list of fields must be sent. Docs.
I should also note that while the fix is very simple, debugging these issues (apart from the recipient list order) was not easy and took me a full day basically, because there's still a lot about this codebase that I don't know.
Tests are passing:
Tested the provider locally multiple times. Worked well in my tests, but please let me know if I can make it easier to review this and to verify.