search

thousandeyes / terraform-provider-thousandeyes

ThousandEyes Terraform Provider
Apache License 2.0
21 stars 26 forks source link

feat: added ip addresses to agent data source #150

Closed joaomper-TE closed 8 months ago

joaomper-TE commented 8 months ago

As requested within #128 by several users this adds ip addresses to the Agent DataSource:

Changes to Outputs:
  + agent_id     = 123213
  + agent_name   = "Vancouver, Canada"
  + ip_addresses = [
      + "155.313.108.19",
      + "155.313.108.23",
      + "155.313.108.15",
      + "2607:f6f3:3400:96::2:7",
      + "2607:f6f3:3400:96::2:4",
    ]
╷
brumarqu-te commented 8 months ago

i'm not sure but from the referenced issue seems that customer needs the publicIpAddresses. We need to pull in the IP addresses of agent in Sao-paulo Brazil for example and then allow those IP's on our network firewall

joaomper-TE commented 8 months ago

i'm not sure but from the referenced issue seems that customer needs the publicIpAddresses. We need to pull in the IP addresses of agent in Sao-paulo Brazil for example and then allow those IP's on our network firewall

Yeah, that's a fair question. I asked yesterday in the GH issue to make sure which IP Addresses the user is referring to (will only merge this afterwards)