It seems to conflict with the fix that was done here for #73. However, was trying out the scenarios from #73 locally:
Create test with alerts_enabled set to true and without specifying any alert rule
Create test with alerts_enabled set to false and with 2 alert rules, one of them being a default alert rule
Remove one of the alert rules from a test which had 2 alert rules
and both Terraform plan/apply, as well as subsequent terraform plans, ran ok (and the subsequent terraform plans showed no changes).
@raul-te not sure if you have any objection or know anything else that I should further test before merging this. Because it does seems that filtering out the Default Alert Rules is no longer needed...
NOTE: We do need some tests for this repo though, as we should have more visibility when fixing something do make sure that we don't introduce any regression.
This fixes #111 .
It seems to conflict with the fix that was done here for #73. However, was trying out the scenarios from #73 locally:
alerts_enabledset totrueand without specifying any alert rulealerts_enabledset tofalseand with 2 alert rules, one of them being a default alert ruleand both Terraform plan/apply, as well as subsequent terraform plans, ran ok (and the subsequent terraform plans showed no changes).
@raul-te not sure if you have any objection or know anything else that I should further test before merging this. Because it does seems that filtering out the Default Alert Rules is no longer needed...
NOTE: We do need some tests for this repo though, as we should have more visibility when fixing something do make sure that we don't introduce any regression.